-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: terraform attempts to change the CODEOWNERS on archived repos #54
Comments
That's a tricky one. So we archived one repository Line 161 in 379dff8
That's possible by replacing it with the following:
However, Terraform then tries to remove the integrations/terraform-provider-github#737 sounds like a related issue. Does anyone with more Terraform experience has a good idea for this? @DavidLambauer @Jakski @mautz-et-tong |
I tried to achieve it with ignore_changes, but I've got the same error as described on forum - it seems that we can't set this attribute from variables. Without waiting for integrations/terraform-provider-github#737 to resolve, we have at least 2 options:
|
I would vote for the first approach. Would you be willing to create a PR for this, @Jakski? |
Any update on this, @Jakski? Thanks! |
@sprankhub do we actually need the archived repos in the tf state? What about just removing them from the state and that's it? |
@DavidLambauer, are you sure this actually works? Wouldn't Terraform then complain that there is a repository, which is not managed by Terraform? Or what about just deleting that repository altogether? 😂 |
If you delete the state, tf will most likely try to add it again. We’d need to drop it from the `variables.tf` as well.
|
Let's discuss how to handle this in the next tech meeting. |
Sorry for delay. #64 should solve the issue.
Correct. |
See: https://github.com/mage-os/terraform/actions/runs/4861725626/jobs/8667116974#step:6:440
The text was updated successfully, but these errors were encountered: