-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging is blocked #91
Comments
In the tech meeting, we decided that code owners should be able to merge. Things to check:
|
I think this is a regression from the monorepo branch protection at ea3a4d0#diff-dc46acf24afd63ef8c556b77c126ccc6e578bc87e3aa09a931f33d9bf2532fbb Previously there was no So I suppose the question is whether we want to go back to the prior behavior (which probably did allow codeowners to push to branches), or refactor for more fine grained control. If the prior behavior is okay, I think this would maybe handle it?. Untested speculation.
Point of concern: Does this block mage-os-ci from pushing on non-monorepo repositories? |
PR opened based on that thinking: #95 |
I tested this now. When merging the PR, code owners can indeed push new branches. However, they cannot push to existing branches:
Also, merging the PR will indeed lead to the fact that code owners can merge approved PRs. |
Use team IDs instead of names, #91
Somehow, it seems to be impossible to merge PRs even if they have enough approvals. An example would be mage-os/mageos-async-events-sinks#5:
It looks like merging is currently not possible for anyone but @Vinai.
The text was updated successfully, but these errors were encountered: