Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare optional argument values for intercepted methods #325

Open
dmitrii-fediuk opened this issue Aug 5, 2023 · 1 comment
Open

Declare optional argument values for intercepted methods #325

dmitrii-fediuk opened this issue Aug 5, 2023 · 1 comment
Labels
code-generation refactoring

Comments

@dmitrii-fediuk
Copy link
Member

dmitrii-fediuk commented Aug 5, 2023 •
edited
Loading

It is needed because Magento does not pass the values of missed optional arguments of intercepted methods to plugins.
dmitrii-fediuk added a commit to mage2pro/currency-format that referenced this issue Aug 6, 2023
@dmitrii-fediuk
https://github.com/mage2pro/core/issues/325
9dd0e7c
dmitrii-fediuk added a commit to mage2pro/currency-format that referenced this issue Aug 6, 2023
@dmitrii-fediuk
https://github.com/mage2pro/core/issues/325
2e0efd3
dmitrii-fediuk added a commit to mage2pro/currency-format that referenced this issue Aug 6, 2023
@dmitrii-fediuk
https://github.com/mage2pro/core/issues/325
868564b
@dmitrii-fediuk dmitrii-fediuk mentioned this issue Aug 6, 2023
Closed
dmitrii-fediuk added a commit to mage2pro/currency-format that referenced this issue Aug 6, 2023
@dmitrii-fediuk
https://github.com/mage2pro/core/issues/325
2aa9aec
@dmitrii-fediuk dmitrii-fediuk mentioned this issue Aug 6, 2023
Open
@dmitrii-fediuk
Copy link
Member Author

dmitrii-fediuk commented Aug 6, 2023 •
edited
Loading

If an optional argument is missed from an intercepted method call, then plugins will not get the argument's value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-generation refactoring
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmitrii-fediuk