Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php 8.2 Compatibility #914

Open
fooman opened this issue Mar 14, 2023 · 7 comments
Open

Php 8.2 Compatibility #914

fooman opened this issue Mar 14, 2023 · 7 comments

Comments

@fooman
Copy link

fooman commented Mar 14, 2023

Preconditions

  1. php 8.2
  2. Magento 2.4.6

Steps to reproduce

  1. install data migration tool
  2. run Magento compilation: bin/magento setup:di:compile

Expected result

  1. no error

Actual result

In ErrorHandler.php line 62:

Deprecated Functionality: Creation of dynamic property Migration\Logger\FileHandler::$filesystem is deprecated in /var/www/vendor/magento/data-migration-tool/src/Migration/Logger/FileHandler.php on line 50

Additional notes

@m2-assistant
Copy link

m2-assistant bot commented Mar 14, 2023

Hi @fooman. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

@oceane410
Copy link

I had the same problem and hot fix it on my side (by declaring these missing properties)
There are also issue when launching php bin/magento migrate:data

  • Deprecated Functionality: Creation of dynamic property Migration\Step\Eav\Helper::$source is deprecated in data-migration-tool/src/Migration/Step/Eav/Helper.php on line 68
  • Deprecated Functionality: Creation of dynamic property Migration\Step\Customer\Model\SourceRecordsCounter::$entityTypeCode is deprecated in /data-migration-tool/src/Migration/Step/Customer/Model/SourceRecordsCounter.php on line 48

@mustafaslk
Copy link

php bin/magento migrate:data -a app/code/Vendor/Migration/etc/opensource-to-opensource/1.9.4.0/config.xml

Screenshot_5

@jesse-deboer
Copy link
Contributor

jesse-deboer commented Apr 24, 2023

@magento I am working on this

Created a PR for this: #917. In the meantime you can use this as a patch: https://patch-diff.githubusercontent.com/raw/magento/data-migration-tool/pull/917.patch

@m2-assistant
Copy link

m2-assistant bot commented Apr 24, 2023

Hi @jesse-deboer! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@jesse-deboer
Copy link
Contributor

@victor-v-rad is it possible to merge this one to also give support for PHP 8.2?

@deemantha22
Copy link

deemantha22 commented May 15, 2023

Hi,

I am getting the same error on M 246 PHP 8.2

Deprecated Functionality: Creation of dynamic property Migration\Logger\FileHandler::$filesystem is deprecated

added protected $filesystem; and it fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants