Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update laminas/laminas-escaper composer dependency to the latest version (>=2.8.0) #33574

Closed
andrewbess opened this issue Jul 23, 2021 · 2 comments
Assignees
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: Platform Health

Comments

@andrewbess
Copy link

We need updating laminas/laminas-escaper composer dependency to the latest version (>=2.8.0).

Attention. Currently, the escaper from Magento Framework incompatible with laminas/laminas-escaper >= 2.7.1.
This can be checked in this issue.
We have fixes of this problem here.
So, we should merge fixes previously.

Also, PRs should contains updated versions of the laminas/laminas-escaper in composer.json and composer.lock files in all dependent repositories (EE, MFTF) in Magento.

Related Issues

  1. Fixes Latest laminas/laminas-escaper (2.7.0 -> 2.7.1) breaks product and catalog category view pages #33346

Related Pull Requests

Fix incompatibility with laminas-escaper (2.7.1) #33353

Expected result (*)

  1. The laminas/laminas-escaper composer dependency should be updated to the latest version >= 2.8.0.
  2. The system works correctly.
@andrewbess andrewbess added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Platform Health labels Jul 23, 2021
@andrewbess andrewbess self-assigned this Jul 23, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jul 23, 2021

Hi @andrewbess. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Jul 23, 2021

Hi @andrewbess. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: Platform Health
Projects
None yet
Development

No branches or pull requests

1 participant