Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Add missing REST methods to Curl Client (SwiftOtter's SOP-348) #39341

Open
5 tasks
m2-assistant bot opened this issue Nov 7, 2024 · 2 comments · May be fixed by #39330
Open
5 tasks

[Issue] Add missing REST methods to Curl Client (SwiftOtter's SOP-348) #39341

m2-assistant bot opened this issue Nov 7, 2024 · 2 comments · May be fixed by #39330
Assignees
@lbajsarowicz @engcom-Hotel
Labels
feature request Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 7, 2024

This issue is automatically created based on existing pull request: #39330: Add missing REST methods to Curl Client (SwiftOtter's SOP-348)

Description (*)

There are 9 methods in the HTTP protocol (https://en.wikipedia.org/wiki/HTTP).
Magento implements just 2 of them, so when you need to make requests to remote environments using Framework HTTP Client, you end up with HTTP 411 error.

This Pull Request adds missing methods with their payload support:

  • PUT
  • PATCH
  • DELETE

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P3 May be fixed according to the position in the backlog. label Nov 7, 2024
@m2-assistant m2-assistant bot linked a pull request Nov 7, 2024 that will close this issue
Open
6 tasks
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Nov 29, 2024
@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Nov 29, 2024
@engcom-Hotel engcom-Hotel self-assigned this Nov 29, 2024
@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented Nov 29, 2024

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel
Copy link
Contributor

Hello @lbajsarowicz,

Thanks for the contribution!

After looking into the PR, it seems that it is not a bug but we can mark it as a Feature Request.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbajsarowicz lbajsarowicz

@engcom-Hotel engcom-Hotel

Labels
feature request Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Issue Confirmation and Triage Board
Status: Ready for Confirmation
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing REST methods to Curl Client (SwiftOtter's SOP-348) lbajsarowicz/magento2
3 participants
@lbajsarowicz @engcom-Bravo @engcom-Hotel