Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kryo v5 support #128

Open
wyhasany opened this issue Jan 7, 2021 · 10 comments
Open

Kryo v5 support #128

wyhasany opened this issue Jan 7, 2021 · 10 comments

Comments

@wyhasany
Copy link

wyhasany commented Jan 7, 2021

Do you plan to support Kryo v5? Main readme says that you support only v2, v3, v4 versions. Is it very hard to implement v5 support?

@l0rinc
Copy link

l0rinc commented Jun 3, 2021

Any progress with unmodifable collection support for Kryo5?

@theigl
Copy link
Collaborator

theigl commented Jul 16, 2021

Kryo 5 can be used without problems. The Readme just doesn't reflect that.

@l0rinc
Copy link

l0rinc commented Jul 16, 2021

Could you add an example on how to do that exactly?
We ended up reimplementing all the unmodifable collection serializers for Kryo 5.

@theigl
Copy link
Collaborator

theigl commented Jul 16, 2021

@paplorinc: What kind of issue did you have? I'm using Kryo 5 and simply call:

	UnmodifiableCollectionsSerializer.registerSerializers(kryo);
	SynchronizedCollectionsSerializer.registerSerializers(kryo);

The latest version of this project already depends on an old Kryo 5 RC so this works fine for me.

@theigl
Copy link
Collaborator

theigl commented Jul 16, 2021

@magro: Any chance you could bump the Kryo dependency to the latest release and update the readme?

@l0rinc
Copy link

l0rinc commented Jul 16, 2021

We depend on both version of Kryo, so we're getting:
image

@theigl
Copy link
Collaborator

theigl commented Jul 16, 2021

OK, that's bad. I guess this wasn't taken into account when the separate Kryo 5 artifact was created. This will be tough to fix.

Since unmodifable collections are part of the JDK, we could add built-in support for them to Kryo. Some of the serializers where already moved over to Kryo in the past. I don't know why these weren't included.

@theigl
Copy link
Collaborator

theigl commented Jul 16, 2021

It seems that has been discussed a couple of times in the past:

Nate was against including any "unsafe" serializers, i.e. serializers depending on internal state of the objects not available through public APIs.

@marcphilipp
Copy link

Are there any updates on this?

@alejandrod-f
Copy link

I hope this is done soon! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants