Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization/Fix] (HQ) Audio Preview #11

Open
Calemy opened this issue Jun 25, 2023 · 0 comments
Open

[Optimization/Fix] (HQ) Audio Preview #11

Calemy opened this issue Jun 25, 2023 · 0 comments

Comments

@Calemy
Copy link

Calemy commented Jun 25, 2023

I noticed that the audio previews are loaded on the MapsetCard directly when generated.
That approach is good for pre-rendering but by far not optimized for traffic.

My suggestion is to only load "new Audio()" when the beatmap actually is being clicked to play to avoid unnecessary traffic.
With this High Quality previews by catboy.best should also work without any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant