Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

More unit tests needed + Upload code coverage to CodeCov #215

Open
miparnisari opened this issue Jan 22, 2024 · 1 comment
Open

More unit tests needed + Upload code coverage to CodeCov #215

miparnisari opened this issue Jan 22, 2024 · 1 comment

Comments

@miparnisari
Copy link
Contributor

make test in master currently reports 49.0% code coverage overall. There are multiple critical code paths not covered with tests. For example:

  • algorithms.go only has 81% and is arguably the most important piece of code.
  • global.go only has 84.2% and has no unit tests (😱)

It would be nice if, going forward, we block PRs that do not include tests. I suggest enabling Codecov through https://github.com/marketplace/codecov and uploading code coverage in every PR and for every push to main.

For example: https://github.com/openfga/openfga/blob/164963facc61241e1378d8fefb6632c700407163/.github/workflows/pull_request.yaml#L49-L57

The end goal would be the overall code coverage to a healthier number.

@Baliedge
Copy link
Contributor

I think it would be sufficient to link make test to a GitHub Action that indicates a threshold as a warning, though would be best not to enforce it for now.

Some quick searches revealed:

This would be a welcome addition to the repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants