You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
make test in master currently reports 49.0% code coverage overall. There are multiple critical code paths not covered with tests. For example:
algorithms.go only has 81% and is arguably the most important piece of code.
global.go only has 84.2% and has no unit tests (😱)
It would be nice if, going forward, we block PRs that do not include tests. I suggest enabling Codecov through https://github.com/marketplace/codecov and uploading code coverage in every PR and for every push to main.
I think it would be sufficient to link make test to a GitHub Action that indicates a threshold as a warning, though would be best not to enforce it for now.
make test
inmaster
currently reports 49.0% code coverage overall. There are multiple critical code paths not covered with tests. For example:algorithms.go
only has 81% and is arguably the most important piece of code.global.go
only has 84.2% and has no unit tests (😱)It would be nice if, going forward, we block PRs that do not include tests. I suggest enabling Codecov through https://github.com/marketplace/codecov and uploading code coverage in every PR and for every push to
main
.For example: https://github.com/openfga/openfga/blob/164963facc61241e1378d8fefb6632c700407163/.github/workflows/pull_request.yaml#L49-L57
The end goal would be the overall code coverage to a healthier number.
The text was updated successfully, but these errors were encountered: