Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Simplify SetupDaemonConfig API #217

Open
miparnisari opened this issue Jan 24, 2024 · 0 comments
Open

Simplify SetupDaemonConfig API #217

miparnisari opened this issue Jan 24, 2024 · 0 comments

Comments

@miparnisari
Copy link
Contributor

miparnisari commented Jan 24, 2024

This function really really shouldn't accept a concrete instance of a logrus.Logger. This should be an interface and, if consumers want, they can pass their own implementation (or a NoOpLogger)

Something else I noticed: it is really really easy for consumers of this project to simply do gubernator.SpawnDaemon(ctx, DaemonConfig{GRPCListenAddress: "localhost:8111"}) - this will set all other configs to their zero values! 😱

Originally posted by @miparnisari in #214 (comment)

@miparnisari miparnisari changed the title Simplifyi SetupDaemonConfig API Simplify SetupDaemonConfig API Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant