You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
This function really really shouldn't accept a concrete instance of a logrus.Logger. This should be an interface and, if consumers want, they can pass their own implementation (or a NoOpLogger)
Something else I noticed: it is really really easy for consumers of this project to simply do gubernator.SpawnDaemon(ctx, DaemonConfig{GRPCListenAddress: "localhost:8111"}) - this will set all other configs to their zero values! 😱
This function really really shouldn't accept a concrete instance of a
logrus.Logger
. This should be an interface and, if consumers want, they can pass their own implementation (or a NoOpLogger)Something else I noticed: it is really really easy for consumers of this project to simply do
gubernator.SpawnDaemon(ctx, DaemonConfig{GRPCListenAddress: "localhost:8111"})
- this will set all other configs to their zero values! 😱Originally posted by @miparnisari in #214 (comment)
The text was updated successfully, but these errors were encountered: