Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailgun-js beaks got #265

Open
zdila opened this issue Jun 19, 2020 · 4 comments
Open

mailgun-js beaks got #265

zdila opened this issue Jun 19, 2020 · 4 comments

Comments

@zdila
Copy link

zdila commented Jun 19, 2020

Just adding require('mailgun-js'); makes got failing.

const got = require('got');

require('mailgun-js');

got.get(`https://www.google.com/`).then(
  (res) => {
    console.log('DONE', res.headers);
  },
  (err) => {
    console.error('ERROR', err);
  },
);

Requirements:

"dependencies": {
    "got": "^11.3.0",
    "mailgun-js": "^0.22.0"
  }
@tobyhinloopen
Copy link

Same or similar error:

https://github.com/tobyhinloopen/openid-client-mailgun-js

@axmachina
Copy link

I can confirm this with the issue i've been encountering with shopify-api-node

MONEI/Shopify-api-node#446

Specifically, mailgun breaks https.request and causes it to drop path from requests ("GET /" vs "GET /some/path").

@axmachina
Copy link

0.11.3
https://github.com/mailgun/mailgun-js-boland/releases/tag/v0.11.3

appears to be the culprit

@dkoleary88
Copy link

Has anyone found a fix or workaround for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants