Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manuel registration doesn't work #176

Closed
cemezgin opened this issue Feb 20, 2024 · 2 comments
Closed

Manuel registration doesn't work #176

cemezgin opened this issue Feb 20, 2024 · 2 comments

Comments

@cemezgin
Copy link
Contributor

cemezgin commented Feb 20, 2024

I want to use clickhouse with the datadog tracing.
https://pkg.go.dev/gopkg.in/DataDog/dd-trace-go.v1/contrib/database/sql

But because of driver is not exported, i am not able to register and use driver.

func init() {
	sql.Register("chhttp", new(chDriver))
}

// chDriver implements sql.Driver interface
type chDriver struct {
}

// Open returns new db connection
func (d *chDriver) Open(dsn string) (driver.Conn, error) {
	cfg, err := ParseDSN(dsn)
	if err != nil {
		return nil, err
	}
	return newConn(cfg), nil
}

Is there any reason why it is not exported?

@DoubleDi
Copy link
Collaborator

Thanks for the usecase. PR welcome to export the driver

@cemezgin
Copy link
Contributor Author

#177
Pr is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants