Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console: Timelapse Output don`t get ignored #2036

Open
Manu45er opened this issue Oct 28, 2024 · 2 comments
Open

Console: Timelapse Output don`t get ignored #2036

Manu45er opened this issue Oct 28, 2024 · 2 comments
Labels
💤 Stale ⚡ Type: Bug Something isn't working ❔ User Input Further information is requested

Comments

@Manu45er
Copy link

Mainsail Version:

2.12

Browser:

Chrome

Device:

Desktop PC

Operating System:

Windows

What happened?

While having Timelapse disabled and Hide Timelapse in Console Filter activated.
I get following Console Output:
"Timelapse: disabled, take frame ignored"
image

What did you expect to happen instead?

Since I´m not using timelapse for every print, it would be great if these messages also get filtered.

How to reproduce this bug?

In Superslicer im using:

Before layer change G-code:
TIMELAPSE_TAKE_FRAME

and turn off Timelapse before print via Mainsail Ui.

Additional information:

Thanks for your great work !

This was my first Git Issue, I hope its fine.

@Manu45er Manu45er added the ⚡ Type: Bug Something isn't working label Oct 28, 2024
@meteyou
Copy link
Member

meteyou commented Dec 21, 2024

Hey @Manu45er! Thx for your Report and sry for the delay!

I checked your FR today and I think there is a "miss interpretation" about "Hide Timelapse" option in the console panel menu. It only hides gcodes/commands. For example if you restart Klipper, the moonraker plugin will send a TIMELAPE_SETUP command. Something like that should be hidden. Your output in the example above is a "Verbose" output:
image

So all "Timelapse:" outputs are "Verbose outputs", and I think these should be hidden with the option in the menu, because these outputs are "disabled" per default and if the user needs some debug/verbose outputs, he/she should "just see it" if he/she enables it.

@meteyou meteyou added the ❔ User Input Further information is requested label Dec 21, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2025

Ahoi!

It looks like there hasn't been any recent updates on
this issue. If you created this issue and no longer
consider it to get merged, then please login to github
and close it. Otherwise, if there is no further activity
on this issue, it will be automatically closedwithin the
next 7 days.

Fair wind and a following sea!
~ Your friendly MainsailGithubBot

PS: I'm just an automated script, not a real sailor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💤 Stale ⚡ Type: Bug Something isn't working ❔ User Input Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants