Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require CODEOWNERS and show (un)covered files #35

Open
at15 opened this issue Dec 31, 2017 · 0 comments
Open

Require CODEOWNERS and show (un)covered files #35

at15 opened this issue Dec 31, 2017 · 0 comments
Labels
priority/P1 process/not claimed type/feature

Comments

@at15
Copy link
Collaborator

at15 commented Dec 31, 2017 •
edited
Loading

This is a feature request

GitHub introduced code owners in July 2017

This new feature automatically requests reviews from the code owners when a pull request changes any owned files

With protected branches enabled, a code owner for each owned file has to leave a review before anyone can merge a pull request to that branch

It would be good if

  • maintainer generates an empty CODEOWNERS file or warn if a existing repo doesn't have one (I don't know if maintainer has a health check like feature)
  • show the coverage of CODEOWNERS, i.e. some files are not covered

I think k8s already have something similar long time ago, i.e. api/OWNERS. And it's similar to pullapprove in some sense
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/P1 process/not claimed type/feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaocegege @at15