Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foobar2000] Add support for x64 (x86 64-bit) #236

Open
koitsu opened this issue Apr 27, 2023 · 5 comments
Open

[foobar2000] Add support for x64 (x86 64-bit) #236

koitsu opened this issue Apr 27, 2023 · 5 comments
Assignees

Comments

@koitsu
Copy link

koitsu commented Apr 27, 2023

https://wiki.hydrogenaud.io/index.php?title=Foobar2000:Version_2.0_Release_Notes

https://www.foobar2000.org/download

https://www.foobar2000.org/getfile/foobar2000-x64_v2.0.exe

@majkinetor
Copy link
Owner

Nice. Thx for the info !

@majkinetor majkinetor self-assigned this Apr 27, 2023
@koitsu
Copy link
Author

koitsu commented Apr 27, 2023

Oh, one thing I should add: fb2k x64 is not compatible with x86/32-bit fb2k components.

So users may want to consider using choco install --forcex86 foobar2000 even on x64 systems to ensure they get the 32-bit foobar2000 package (if they have reason to, i.e. use components that do not support x64).

This isn't something you have to fix in your Chocolatey scripts, but I wanted to mention it here in case it comes up.

@majkinetor
Copy link
Owner

majkinetor commented Apr 27, 2023

I can add a note about it in package.

But, the existing users will have a problem - now for them, it will update to x64 and all plugins will stop working. Especially since choco still doesn't remember install arguments for update (and who knows when will it get to be default). So perhaps, I should delay this as it will literary break all current installations on update.

@koitsu
Copy link
Author

koitsu commented Apr 27, 2023

That's a fair point! I suppose an alternate solution might be to make a separate foobar2000-x64 package and submit that to the Chocolatey folks for review. Otherwise, yeah, an in-place upgrade (from x86 to x64) could indeed cause plugins to no longer function.

@majkinetor
Copy link
Owner

I doubt there is much benefit of using x64 bit version of foobar2k anyway particularly now when plugins yet have to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants