Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React integration #67

Open
mikolaszko opened this issue Aug 10, 2023 · 3 comments
Open

React integration #67

mikolaszko opened this issue Aug 10, 2023 · 3 comments

Comments

@mikolaszko
Copy link

Hi :)
I am aware that this is a shelved project but I was just wondering, how hard is it/would be to integrate this plugin with react-leaflet? I might need it for my professional work and I am just curious

@babastienne
Copy link
Member

@mabhub or @Bo-Duke or @dtrucs might be able to answer this question ?

This is not an abandoned lib, we still use it in some projects.

@Bo-Duke
Copy link
Member

Bo-Duke commented Aug 11, 2023

It is indeed far from shelved, we actually have updates planned!

The demo and Readme will soon be updated to show that the project is very well alive 😉

Concerning React-leaflet, it's not something planned for the moment but it can be if the work involved is manageable? Do you know what you need for it to be usable with React-leaflet? Do you have examples of other plugins? IIRC, most big plugins have a dedicated react version.

@mikolaszko
Copy link
Author

mikolaszko commented Aug 11, 2023

@Bo-Duke currently only about only ~11-20 plugins have been developed for the newest react-leaflet version and that just seems really limiting. (that's whats listed on the NPM for the v4 and I know that react-leaflet-draw is not listed on there) I don't know the whole scope so far, but svelte would probably integrate easily with all of the original leaflet plugins like yours!
I will definitely need to display user updated images as maps, to be able to draw on them (I know this is possible to do with react-leaflet and react-leaflet-draw) and the snap functionality when drawing polygonal shapes on top of all the other things that I will review once I get the spec. I am not expecting the team behind this package to implement anything to make this happen but just by nature if everything requires a wrapper for react to work it will be much more difficult and time consuming 😅

@babastienne @Bo-Duke the master branch hasn't been updated for year and a half and I realize that open source work is difficult and time consuming but thats from where my assumption came

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants