Bug When Counting Objects Undeleted by the Admin

[ShmuelTreiger]

New to the project, this seems like a bug to me, but perhaps I'm wrong:

The first 4 messages were all when I successfully undeleted all the objects I selected (i.e. I selected 2 objects and successfully undeleted both), whereas the last message was when I undeleted 8 out of 100 objects (i.e. I selected 100 objects and 8 were undeleted). I'm thinking that perhaps the two messages are mixed up?

Doesn't really matter to me, overall the project works great, just thought I'd raise the issue.

Thanks

[Gagaro]

Hi, thanks for the report.
I'm not sure what's up here, I'm not even sure we are counting the changed objects from the right queryset from looking at the code.

Feel free to do a PR if you have a fix.

[ShmuelTreiger]

Spent some time looking at the code, but I don't think I have enough experience with Django to diagnose the problem and I don't have the time ATM to actually debug it. I guess we can leave this open and perhaps you or I (or someone else) will get around to it one day 🤷‍♂️

[jerivas]

The wrong admin messages happen when the action you just took removes the elements from the current view. For example when you are filtering by "Only deleted" and undelete an element you are taken back to "Only deleted" and the recently undeleted element is not there anymore, which somehow trips up the message logic.

A workaround might be to always return the user to a view where all items (deleted or not) are visible, instead of preserving their previous filters.