Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is python3 required? #2

Open
rsharris opened this issue Jul 2, 2019 · 3 comments
Open

Is python3 required? #2

rsharris opened this issue Jul 2, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@rsharris
Copy link
Contributor

rsharris commented Jul 2, 2019

I was trying to run this using python2 (because I didn't know any better). I get an exception from str.maketrans() on kmers.py. In python2 (apparently) string objects don't have a maketrans method, whereas (I guess) in python3 they do.

If the package isn't intended to support python2, it would be nice to say that in the readme.

@md5sam
Copy link
Contributor

md5sam commented Jul 7, 2019

That's interesting : I've only ever used python2.7, so I believe DiscoverY should work fine with python2. Let me look into this and let you know.

@md5sam md5sam added the bug Something isn't working label Jul 7, 2019
@rsharris
Copy link
Contributor Author

rsharris commented Jul 8, 2019

Discussed this with Tasha. She achieved some speedups by converting to python3. Backward compatibility with python2 wasn't maintained. Probably reasonable since python2 wil lbe a problem for all of us after Jan/1/2020.

The readme should be modified to reflect that, though.

@rsharris
Copy link
Contributor Author

For my present effort, which is just running the example so I know how to run this, I've just modified my copy of the source code so that it runs under python2. The only change I had to make was that use of maketrans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants