Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAG parser can create task with nulled input jobs #20

Open
Mequrel opened this issue Apr 20, 2013 · 1 comment
Open

DAG parser can create task with nulled input jobs #20

Mequrel opened this issue Apr 20, 2013 · 1 comment

Comments

@Mequrel
Copy link
Collaborator

Mequrel commented Apr 20, 2013

task.getInputFiles() or task.getOutputFiles should never return null. It's better to return empty list.

Please remove also null sanity checks from DAGDynamicScheduler

@bryk
Copy link
Collaborator

bryk commented Apr 20, 2013

Side comment: there are plenty of sanity checks everywhere. I'd be better if we had unit test instead :)
But the code is already written, so we have somehow to live with this.

I agree that incremental removal of sanity checks and additions of unit tests is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants