Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afile.txt is needlessly ridiculously large #21

Open
apisarenco opened this issue Jul 30, 2017 · 2 comments · May be fixed by #24
Open

afile.txt is needlessly ridiculously large #21

apisarenco opened this issue Jul 30, 2017 · 2 comments · May be fixed by #24

Comments

@apisarenco
Copy link

What's the point in afile.txt test fixture? The test is just reading every line of that file and testing if it's not null. With the same success you can have 10 lines of random ASCII characters and not add 1800KB on top of the 1.8KB of code and make it 1000 times bigger.
If it's a stress test, then maybe just repeat the test 1000 times.

Plus, as the text reads, "Be sure to check the copyright laws for your country before downloading or redistributing this or any other Project Gutenberg eBook.". Yet this library does not come with a license agreement, and should not need one, and thus should definitely not contain any content that the copyright holder has not renounced all rights to. Therefore this book shouldn't be here even from a legal perspective.

@adipascu
Copy link

Relevant blog post https://talbrenev.com/2019/04/16/sherlock-holmes.html

@koskimas
Copy link

The file should just be excluded from the distributed package. You can use the files field in package.json to specify the files to distribute.

@barbeque barbeque linked a pull request Apr 17, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants