Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextend Accordion Menu #20

Open
tcf909 opened this issue Apr 9, 2019 · 8 comments
Open

Nextend Accordion Menu #20

tcf909 opened this issue Apr 9, 2019 · 8 comments

Comments

@tcf909
Copy link

tcf909 commented Apr 9, 2019

Hello,

I'm trying to use page-scroll-to-id with Nextend Accordion Menu. For some reason I don't believe page-scroll-to-id is being used when clicking the links. I've selected the option to try to disable other handlers, but still nothing. I've also opened up the selector to just "a" to see if it would work and it doesn't.

Hoping you can help as I really like your plugin, but need accordion menus to reduce size of content.

Same url as prior ticket.

@malihu
Copy link
Owner

malihu commented Apr 9, 2019

Hi,

Have you created the targets? Are the accordion menu links point to those targets?
Can you post your URL?

@tcf909
Copy link
Author

tcf909 commented Apr 9, 2019

I went ahead and re-enabled the menu that isn't working correctly:

https://www.digitalspaces.app/documentation/

@tcf909
Copy link
Author

tcf909 commented Apr 10, 2019

@malihu Any thoughts on what might be going on?

I'm getting ready to launch this website (maybe as early as tomorrow), hoping to lock this down.

Really appreciate the help.

@tcf909
Copy link
Author

tcf909 commented Apr 10, 2019

Just to confirm:

You first need to hit this link:
https://www.digitalspaces.app/?ucp-access=94e6e732

To be granted access to:
https://www.digitalspaces.app/documentation/

@malihu
Copy link
Owner

malihu commented Apr 11, 2019

Go to "Page scroll to id" settings and enable "Prevent other scripts from handling plugin’s links" option. Save changes and test your page.

@tcf909
Copy link
Author

tcf909 commented Apr 11, 2019

I've enabled that in the past to see if it fixed it -- not so. Enabled it again just now and left it enabled.

I also opened up a ticket with the company that does the menu and asked to disable whatever scroll to functionality they have and they responded with:

"We do not provide any scroll to anchor functionality as part of our plugin."

So I'm left wondering what is going on. Any guidance you can provide is appreciated.

@tcf909
Copy link
Author

tcf909 commented Apr 14, 2019

Thought I would follow up. Haven't been able to figure out what might be causing this. The format of the actual html in the menu is quite a bit different -- don't know if that has something to do with it?

@malihu
Copy link
Owner

malihu commented Apr 14, 2019

Hello again,

It seems that a specific script prevents "Page scroll to id" from scrolling the page. The script that does this is, is this one:

https://www.digitalspaces.app/wp-content/cache/js/static/cc47c34a5d4b0798d89cc99a755c910a.js

You can find the function that does this in line 431-433.

I don't know if this script is part of the menu or another plugin or the theme itself, because it's a cached script. The function naming includes the word dojo (don't know if this makes sense?).

Maybe you could edit the non-cached file of the script and comment the line:

e.cancelBubble = true;

in line 432.

Perhaps this will fix the issue.

The "Prevent other scripts from handling plugin’s links" option cannot always remove other scripts events automatically, meaning the only way to do it is by manually editing the script or see if there's an option to disable such feature.

My guess in your case, is that you'll have to manually edit the script if you want page scrolling plugins to work along with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants