partial support for map based selector conversion #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I examined this a bit further and I think the appropriate result would actually be: source:
sel(not win)
:url "https://example.com/src-code"
patches:
- sel(win): win-specific.patch |
|
I updated the PR to produce valid yaml in more cases and remove the need for the error. It will correctly handle: source:
url: "https://windows.example.com/src-code" # [win]
sha256: 42 # [win]
url: "https://posix.example.com/src-code" # [not win]
sha256: 43 # [not win]
patches:
- win-specific.patch # [win]producing: source:
sel(win):
url: "https://windows.example.com/src-code"
sha256: 42
sel(not win):
url: "https://posix.example.com/src-code"
sha256: 43
patches:
- sel(win): win-specific.patchbut will give a duplicate key error for the following: source:
url: "https://windows.example.com/src-code" # [win]
url: "https://posix.example.com/src-code" # [not win]
sha256: 42 # [win]
sha256: 43 # [not win]
patches:
- win-specific.patch # [win]because it produces: source:
sel(win):
url: "https://windows.example.com/src-code"
sel(not win):
url: "https://posix.example.com/src-code"
sel(win):
sha256: 42
sel(not win):
sha256: 43
patches:
- sel(win): win-specific.patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #385
Turns out the selector parsing did not cover cases where maps have selectors.
Given this meta.yml example:
The existing code produces:
After this pull request you will get:
This example is not fully valid yaml either, but I throw a helpful error.
To fully fix the problem you would need to walk every map and make sure that if any of the map entries have a selector then every map entry is converted to a list entry. I think at that point you're halfway to writing a full yaml parser instead of a preprocessor.
A fully fixed version would produce something like:
A real world example:
https://raw.githubusercontent.com/conda-forge/cmdstan-feedstock/main/recipe/meta.yaml