Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mark micromamba rc's as latest release in github #49

Closed
pavelzw opened this issue Jul 16, 2024 · 6 comments · Fixed by #50
Closed

Don't mark micromamba rc's as latest release in github #49

pavelzw opened this issue Jul 16, 2024 · 6 comments · Fixed by #50

Comments

@pavelzw
Copy link
Member

pavelzw commented Jul 16, 2024

setup-micromamba uses the latest release by default which results in the rc being rolled out to too many users.

image

@pavelzw
Copy link
Member Author

pavelzw commented Jul 16, 2024

@JohanMabille
Copy link
Member

JohanMabille commented Jul 16, 2024

Indeed, this was made by accident and has been fixed in the latest commit.1.5.8 has been flaged to be the latest release again.

@pavelzw
Copy link
Member Author

pavelzw commented Jul 16, 2024

you still need to mark it as not latest in

- name: Release
uses: softprops/action-gh-release@v1
if: steps.fetch-release.outputs.MICROMAMBA_NEW_VERSION == 'true'
with:
name: "micromamba ${{ steps.fetch-release.outputs.MICROMAMBA_VERSION }}"
body: |
Release artifacts for micromamba ${{ steps.fetch-release.outputs.MICROMAMBA_VERSION }}, mirrored from conda-forge.
The full changelog can be found [here](https://github.com/mamba-org/mamba/releases).
tag_name: ${{ steps.fetch-release.outputs.MICROMAMBA_VERSION }}
files: |
releases/*

@wolfv just made it a pre-release manually

image

Once you trigger this workflow a second time for rc1, it will be latest again

@JohanMabille
Copy link
Member

Shouldn't the latest commit prevent this issue?

@pavelzw
Copy link
Member Author

pavelzw commented Jul 16, 2024

not that i can see 🤔 you need to specify prerelease: true for these kinds of releases

https://github.com/softprops/action-gh-release/blob/288696be3916479e99fa944c72825e9b3e192be4/action.yml#L21

@Hind-M
Copy link
Member

Hind-M commented Jul 16, 2024

All dev and prereleases will be skipped when the workflow is triggered automatically unless it's done manually (cf. #46 and #47), but in that case, and if the version is a prerelease, it won't indeed be marked as a prerelease.
#50 should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants