From 7993f293bee655d9b1dd7570777e0f4e65fea0eb Mon Sep 17 00:00:00 2001 From: Ivo Dilov Date: Tue, 5 Nov 2024 11:33:15 +0200 Subject: [PATCH] Skip azure compat tests because of #1979 Also since 4.5.1 is now available we replace 4.5.0 with 4.5.1 which should re-enable the lmdb and mongo tests with their segfaults fixed. --- python/tests/compat/conftest.py | 6 ++++-- python/tests/compat/requirements-4.5.0.txt | 3 --- python/tests/compat/requirements-4.5.1.txt | 3 +++ 3 files changed, 7 insertions(+), 5 deletions(-) delete mode 100644 python/tests/compat/requirements-4.5.0.txt create mode 100644 python/tests/compat/requirements-4.5.1.txt diff --git a/python/tests/compat/conftest.py b/python/tests/compat/conftest.py index 90691479d1..4ae62c49ee 100644 --- a/python/tests/compat/conftest.py +++ b/python/tests/compat/conftest.py @@ -140,7 +140,7 @@ def assert_read(self, sym : str, df) -> None: scope="session", params=[ pytest.param("1.6.2", marks=VENV_COMPAT_TESTS_MARK), - pytest.param("4.5.0", marks=VENV_COMPAT_TESTS_MARK), + pytest.param("4.5.1", marks=VENV_COMPAT_TESTS_MARK), ] # TODO: Extend this list with other old versions ) def old_venv(request): @@ -176,10 +176,12 @@ def arctic_uri(request): @pytest.fixture() def old_venv_and_arctic_uri(old_venv, arctic_uri): - # TODO: Replace 4.5.0 with 4.5.1 when it is released to re-enable both mongo and lmdb. if Version(old_venv.version) <= Version("4.5.0") and arctic_uri.startswith("mongo"): pytest.skip("Mongo storage backend has a desctruction bug present until 4.5.0, which can cause flaky segfaults.") if Version(old_venv.version) <= Version("4.5.0") and arctic_uri.startswith("lmdb"): pytest.skip("LMDB storage backend has a desctruction bug present until 4.5.0, which can cause flaky segfaults.") + if arctic_uri.startswith("azure"): + # TODO: Once #1979 is understood and fixed reenable azure on versions which have the fix. + pytest.skip("Azure storage backend has probable a desctruction bug, which can cause flaky segfaults.") return old_venv, arctic_uri diff --git a/python/tests/compat/requirements-4.5.0.txt b/python/tests/compat/requirements-4.5.0.txt deleted file mode 100644 index 84e0dd5bea..0000000000 --- a/python/tests/compat/requirements-4.5.0.txt +++ /dev/null @@ -1,3 +0,0 @@ -arcticdb==4.5.0 -numpy<2 -pyarrow \ No newline at end of file diff --git a/python/tests/compat/requirements-4.5.1.txt b/python/tests/compat/requirements-4.5.1.txt new file mode 100644 index 0000000000..e10c212307 --- /dev/null +++ b/python/tests/compat/requirements-4.5.1.txt @@ -0,0 +1,3 @@ +arcticdb==4.5.1 +numpy<2 +pyarrow \ No newline at end of file