Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous QoL changes #70

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Miscellaneous QoL changes #70

wants to merge 4 commits into from

Conversation

no92
Copy link
Member

@no92 no92 commented Jan 23, 2023

No description provided.

ArsenArsen
ArsenArsen reviewed Jan 25, 2023
View reviewed changes
xbstrap/base.py Outdated Show resolved Hide resolved
ArsenArsen
ArsenArsen reviewed Jan 25, 2023
View reviewed changes
xbstrap/base.py Outdated Show resolved Hide resolved
@Dennisbonke
Copy link
Member

Bump

Dennisbonke
Dennisbonke approved these changes Apr 2, 2023
View reviewed changes
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArsenArsen
Copy link
Member

my question remains unadressed

@no92
Copy link
Member Author

no92 commented Apr 11, 2023

Also fixes #71.

@ArsenArsen
Copy link
Member

Also fixes #71.

this fix should be in the schema

@no92
Copy link
Member Author

no92 commented Aug 9, 2023

Addressed the issues raised before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArsenArsen ArsenArsen ArsenArsen left review comments

@Dennisbonke Dennisbonke Dennisbonke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@no92 @Dennisbonke @ArsenArsen