Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerless tools #74

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Containerless tools #74

merged 1 commit into from
Dec 18, 2023

Conversation

no92
Copy link
Member

@no92 no92 commented Aug 8, 2023

This allows for building tools that don't compile and link against the container but against the host machine. This is useful for building a QEMU in bootstrap for instance:

tools:
  - name: host-qemu
    containerless: true
    from_source: qemu
    configure:
      - args:
        - '@THIS_SOURCE_DIR@/configure'
        - '--prefix=@PREFIX@'
    compile:
      - args: ['ninja']
    install:
      - args: ['ninja', 'install']

This allows the result QEMU to use host libraries, resulting in more features of it being available and not having to ship dozens of host tools.

xbstrap/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@ElectrodeYT ElectrodeYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@FedorLap2006 FedorLap2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the following code can be simplified, since python3 already has builtin function any for ORing all the elements in the iterable.

xbstrap/__init__.py Outdated Show resolved Hide resolved
xbstrap/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@FedorLap2006 FedorLap2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this as well. Didn't see these occurences the first time.

xbstrap/base.py Outdated Show resolved Hide resolved
xbstrap/base.py Outdated Show resolved Hide resolved
xbstrap/base.py Outdated Show resolved Hide resolved
@no92
Copy link
Member Author

no92 commented Sep 3, 2023

Applied the suggested code changes.

@ElectrodeYT
Copy link
Member

Can we get this merged? Having a dmalog Qemu in bootstrap would be really nice, and as far as I can tell, all concerns here have been addressed.

xbstrap/base.py Outdated Show resolved Hide resolved
xbstrap/base.py Outdated Show resolved Hide resolved
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@no92 no92 merged commit 4022048 into managarm:master Dec 18, 2023
3 checks passed
@no92 no92 deleted the containerless-tools branch December 18, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants