Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the Windows Terminal as the default terminal #1093

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Set the Windows Terminal as the default terminal #1093

wants to merge 2 commits into from

Conversation

d35ha
Copy link
Member

@d35ha d35ha commented Jun 14, 2024 •
edited
Loading

Closes #971.
Closes #973.

@d35ha d35ha requested a review from Ana06 June 14, 2024 11:46
@d35ha d35ha self-assigned this Jun 14, 2024
@d35ha d35ha added this to the FLARE-VM 2024 Q2 - P1 milestone Jun 14, 2024
@d35ha d35ha added the 💎 enhancement It is working, but it could be better label Jun 14, 2024
@Ana06
Copy link
Member

Ana06 commented Jun 14, 2024 •
edited
Loading

I am not sure this works as proposed in #971. @d35ha can you provide more details on how this works and how it looks like (maybe adding a screenshot)?

@d35ha
Copy link
Member Author

d35ha commented Jun 14, 2024 •
edited
Loading

@Ana06
I've created a console app, here is how its execution looks before and after setting these registry values:

before

after

Also, running cmd or powershell (from start menu or by double-clicking) opens it in Windows Terminal.

@d35ha
Copy link
Member Author

d35ha commented Jun 14, 2024

@Ana06
#973 is also addressed in this PR.

@Ana06
Copy link
Member

Ana06 commented Jun 18, 2024

@d35ha is proposing using the windows terminal to open the shortcuts in the Tools directory, is this PR achieving this?

@d35ha
Copy link
Member Author

d35ha commented Jun 24, 2024

@Ana06
Any application that requires a console would be assigned the Windows terminal console instead of the the old conhost.exe (that is including the shortcuts under the Tools directory).

Ana06
Ana06 requested changes Jul 1, 2024
View reviewed changes
packages/windows-terminal.vm/tools/chocolateyinstall.ps1
@@ -54,6 +55,12 @@ try {
$label = "Open Terminal here"
$icon = "$executablePath"
VM-Add-To-Right-Click-Menu -menuKey $toolName -menuLabel $label -command $command -menuIcon $icon -type "directory" -background

# Set windows terminal as the default terminal (effective only when OS Build >= 19045.3031)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using 10.0.19045.0 (downloaded from the recommended link in FLARE-VM), so this approach does not work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ana06 Ana06 Ana06 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@d35ha d35ha

Labels
💎 enhancement It is working, but it could be better
Projects
None yet
Milestone
FLARE-VM 2024 Q3 - P1
Development

Successfully merging this pull request may close these issues.

Change new tabs default in Windows terminal to CMD Make Windows Terminal the default to run console apps
2 participants
@d35ha @Ana06