Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Windbg code && fix icon #997

Open
Ana06 opened this issue Apr 16, 2024 · 3 comments · May be fixed by #1058
Open

Simplify Windbg code && fix icon #997

Ana06 opened this issue Apr 16, 2024 · 3 comments · May be fixed by #1058
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better

Comments

@Ana06
Copy link
Member

Ana06 commented Apr 16, 2024

Details

Use $executablePath = "$(where.exe $toolName)" to simplify the code of windbg.vm by executing WinDbg directly instead as a consoleApp. This fixes the icon too.
@Ana06 Ana06 added 💎 enhancement It is working, but it could be better 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Apr 16, 2024
@naacbin
Copy link
Collaborator

naacbin commented May 22, 2024 •
edited
Loading

As mentioned in #1040 we could use https://windbg.download.prss.microsoft.com/dbazure/prod/1-2402-24001-0/windbg.msixbundle to download Windbg as a msi which is handle more easily instead of using AppxPackage that will download the installer. Moreover, this allow versioning of Windbg.

@naacbin
Copy link
Collaborator

naacbin commented May 27, 2024

@Ana06, if you agree I can make the change.

@naacbin naacbin linked a pull request May 27, 2024 that will close this issue
Open
@naacbin
Copy link
Collaborator

naacbin commented May 27, 2024

I had some free time so I did a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor WinDbg install mandiant/VM-Packages
2 participants
@Ana06 @naacbin