Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsisten Byte order in CRC check sum #122

Open
mandulaj opened this issue Mar 27, 2024 · 6 comments
Open

Inconsisten Byte order in CRC check sum #122

mandulaj opened this issue Mar 27, 2024 · 6 comments

Comments

@mandulaj
Copy link
Owner

mandulaj commented Mar 27, 2024

Im using PZEM004t-100A(V3). Im using RX (3) and TX (1). Connected to an AC load and all wires are connected properly. Even the readAddress() is not functioning. I saw in the data sheet that the command format of the master in measuring is Slave Address + 0x04 + Register Address High Byte + Register Address Low Byte + Number
of Registers High Byte + Number of Registers Low Byte + CRC Check High Byte + CRC Check
Low Byte. However in the library, I saw that the CRC low byte came first and CRC high byte second. does this have anything to do with it I cant read and set the address of my pzem from 0xF8 to 0xF7?
It also says that the PZEM has a range of 0x00 to 0xF7 only.

Originally posted by @Jemeeeeer in #26 (comment)

@mandulaj
Copy link
Owner Author

mandulaj commented Mar 27, 2024

I have to have a closer look at this, as this is something I wrote 2 years ago and don't remember the details anymore. However I remember that there was some error-checking functionality that was supposed to be implemented, however never got around to doing it. So Thanks for bringing it up @Jemeeeeer.

@Jemeeeeer
Copy link

can u try to fix/implement the error checking functionality?

@mandulaj
Copy link
Owner Author

mandulaj commented Apr 2, 2024

Yes! This is a high priority now. I just need to make sure that the library doesn't break for existing projects so need to run some checks.

@Jemeeeeer
Copy link

Hello. I would like to follow up on this. Any updates? What seems to be the problem?

@Jemeeeeer
Copy link

Hello. Is there an update?

@mandulaj
Copy link
Owner Author

Hi, I am sorry, I am on my vacation and didn't have any time to look at this. Sorry for the inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants