Contrast issues

[phil294]

Hi! Thanks for this extension. I noticed that in the search bar, when you select text, it is not readable anymore:

Text color should probably be white. I quickly looked into this and it seems that there is no such setting as selection.foreground?? So is there even any way to solve this? If not, I'd suggest setting selection.background to a light grey color instead the dark blue :-/

Another issue: The action buttons on the top right are in the wrong color:

There are actually multiple icons in the top row, but you can barely see them. (GitLens icons, mostly). I also looked into this: Currently, dev tools say

.hc-black .monaco-action-bar .action-item.menu-entry .action-label, .vs-dark .monaco-action-bar .action-item.menu-entry .action-label {
    background-image: var(--menu-entry-icon-dark);
}

If you change this to --meny-entry-icon-light, then it gets readable:

VSCode seems to apply these flags based on the fact that win-nt-theme is marked as a dark theme. Can this be changed to be a light theme? Would also make more sense imo.

[phil294]

The issue for point 2 seems to be in package.json contributes.themes.uiTheme which needs to be "vs" instead of "vs-dark". microsoft/vscode#140006, slack-theme/visual-studio-code#9 (comment), https://code.visualstudio.com/api/references/contribution-points#theme-example.
Cannot find any documentation about this though...

[manekinekko]

Hey, thank you for looking at this. Do you want to send a PR to fix this issue?

[phil294]

Hey, thank you for looking at this. Do you want to send a PR to fix this issue?

sure! #4

don't know what to do about the selection color issue though

[manekinekko]

Closed by #4 and 6539d31