Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versionStrict(true) does not apply to parameters #61

Open
DerBlade opened this issue Aug 2, 2016 · 1 comment
Open

versionStrict(true) does not apply to parameters #61

DerBlade opened this issue Aug 2, 2016 · 1 comment

Comments

@DerBlade
Copy link

DerBlade commented Aug 2, 2016

I am trying to convert a V2.1 Vcard into V4.0 by reading it with your library and writing it to another file. But it seems, that setting 'versionStrict(true)' only removes unsupported properties and not parameters from the output.
For example, the "EMAIL" property has the parameters "INTERNET" and "PRIMARY" in my input file and in the output file they are still present.
Is this a bug, or is this behaviour intended?

@DerBlade DerBlade changed the title versionStrict=true does not apply to parameters versionStrict(true) does not apply to parameters Aug 2, 2016
@mangstadt
Copy link
Owner

Hi DerBlade,

Thank you for reporting this. You are right, versionStrict does not remove unsupported parameter values. I will look into addressing this.

"PRIMARY" is not a valid EMAIL parameter value under any version, so this would always remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants