Add support for Privileged Identity Management Groups #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is a generic type returned from the graph, which maps to different types
manicminer
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Thanks for working on this @oWretch. I think you're right, this will likely need to be merged together. This is looking great so far. I'm not sure if you have any additional methods to add, but once we have some basic tests covering these, we can look at merging this!
Fails due to invalid memory adderess when building the POST request
* Added AuthenticationMethodModes * Updates * Typos * Added client * Updated allowed combinations * Disable paging * Fixed description * Fix Typos * fixed tests * fixed typo * Removed extra defintions * Fixed typo * Added AuthenticationStrength to CA Grant Controls * Update msgraph/models.go Co-authored-by: Tom Bamford <[email protected]> * Added tests * Trigger re-test * trigger re-test * Clean up Auth Strengh Policy after testing * Triggered re-test * Updated policy ID * cleanup tool support authentication stength policies --------- Co-authored-by: bubbletroubles <[email protected]> Co-authored-by: Tom Bamford <[email protected]>
…Controls, or both, but must be explicitly null in the `or` case
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Finally found it, though it is part of the v2 API and not v3 😢
|
I've work out that I can split this into multiple PRs, so I'll start raising those separately and link them here. |
This was referenced Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a prerequisite to addressing hashicorp/terraform-provider-azuread#68.
I think this will (once completed) supersede #240 and close #117.