Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop certain code options #267

Open
manodeep opened this issue Dec 13, 2021 · 1 comment
Open

Drop certain code options #267

manodeep opened this issue Dec 13, 2021 · 1 comment

Comments

@manodeep
Copy link
Owner

While reviewing #258, I realised that perhaps we can retire options like fast_acos, and fast_divide from the code-base. Not sure if we would leave any users out though (or how to go about identifying users that do need those features)

@lgarrison Do you have any thoughts on this?
@lgarrison
Copy link
Collaborator

I've never looked at that part of the code very carefully! On the surface, they sound like useful code options; are they deprecated/not useful in some way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manodeep @lgarrison