Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplified join #14

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

simplified join #14

wants to merge 6 commits into from

Conversation

claireboyd
Copy link
Collaborator

No description provided.

@claireboyd claireboyd linked an issue May 9, 2024 that may be closed by this pull request
fa-etl.py Outdated Show resolved Hide resolved
@claireboyd
Copy link
Collaborator Author

claireboyd commented May 13, 2024

Low hanging fruit changes:

  • polars update to conda env
  • try with bigger memory partition on midway (will take a few days to process)

Refactoring changes:
-inner joins instead of left joins - change logic to start with sales

  • minimize # of cols before the join (i.e., we only need a couple columns from prop).
  • ensure that everything is filtered before the join to reflect criteria in the final universe.
  • (last priority change) break up the joins into separate single scan + join + sink of each file creating multiple staging tables (instead of running multiple joins at the same time)

with these changes, a scan + sink + join pattern should work!

Next steps:

  • get local version working again with these changes (clarity on join logic)
  • deploy small batch on midway
  • set up deployment of larger file on bigmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy successfully on midway
1 participant