Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move common code from IntegratePEaksSkew, IntegratePeaksShoeboxTOF and FindSXPEaksConvolve to separate file #36989

Open
RichardWaiteSTFC opened this issue Mar 6, 2024 · 1 comment · May be fixed by #38789
Open

Move common code from IntegratePEaksSkew, IntegratePeaksShoeboxTOF and FindSXPEaksConvolve to separate file #36989

RichardWaiteSTFC opened this issue Mar 6, 2024 · 1 comment · May be fixed by #38789
Assignees
@warunawickramasingha
Labels
Diffraction Issues and pull requests related to diffraction ISIS Team: Diffraction Issue and pull requests managed by the Diffraction subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Single Crystal Issues and pull requests related to single crystal
Milestone
Release 6.13

Comments

@RichardWaiteSTFC
Copy link
Contributor

Describe the outcome that is desired.
There's actually a lot of code in IntegratePeaksSkew that is used in the other algorithms I wrote later (IntegratePeaksShoeboxTOF and FindSXPeaksConvolve) - in particular the PeakData class.

mantid/Framework/PythonInterface/plugins/algorithms/IntegratePeaksSkew.py

Line 224 in e02aa69

class PeakData:

I think all of the common code used in these algorithms belongs in a separate helper algorithm (I think you have something like this in quasibayes?).
@RichardWaiteSTFC RichardWaiteSTFC added Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: Diffraction Issue and pull requests managed by the Diffraction subteam at ISIS labels Mar 6, 2024
@RichardWaiteSTFC RichardWaiteSTFC added this to the Release 6.10 milestone Mar 6, 2024
@RichardWaiteSTFC RichardWaiteSTFC mentioned this issue Mar 6, 2024
Merged
@RichardWaiteSTFC RichardWaiteSTFC mentioned this issue Oct 2, 2024
Merged
@robertapplin robertapplin removed this from DEVS Dec 10, 2024
@warunawickramasingha warunawickramasingha self-assigned this Jan 31, 2025
@warunawickramasingha warunawickramasingha moved this to In Progress in ISIS Diffraction Jan 31, 2025
@warunawickramasingha warunawickramasingha moved this from Icebox to In progress in Mantid Maintenance Jan 31, 2025
@warunawickramasingha warunawickramasingha linked a pull request Feb 4, 2025 that will close this issue
Open
@sf1919 sf1919 moved this from In progress to Ready for Review in Mantid Maintenance Feb 4, 2025
@warunawickramasingha
Copy link
Contributor

Pull requests created in both mantid and scriptrepository repositories as below

@RichardWaiteSTFC RichardWaiteSTFC moved this from In Progress to In Review in ISIS Diffraction Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warunawickramasingha warunawickramasingha

Labels
Diffraction Issues and pull requests related to diffraction ISIS Team: Diffraction Issue and pull requests managed by the Diffraction subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Single Crystal Issues and pull requests related to single crystal
Projects
ISIS Diffraction
Status: In Review
Mantid Maintenance
Status: Ready for Review
Milestone
Release 6.13
2 participants
@RichardWaiteSTFC @warunawickramasingha