-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to BaseSX to plot result of IntegratePeaksMD and save in pdf #36947
Add method to BaseSX to plot result of IntegratePeaksMD and save in pdf #36947
Conversation
Could not make use of sliceviewer code as can import from mantidqt
And fix bug by returning imax
2d8bf24
to
f5b7fe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works really well, I just had a few suggestions - feel free to push back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, looks really good! Just had a few minor suggestions then happy to approve this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, this PR adds some really nice plotting functionality for the output of IntegratePeaksMD. Works really well, and a test has been added
Description of work
Add static method to
BaseSX
class to allow single-crystal users of SXD and WISH to plot result of IntegratePeaksMD and save in pdfIt plots 3 colorfill plots for each peak, taking the axes and extent for the call to
BinMD
from the peak shape (typically ellipsoid or sphere).The axes of the cut are along the eigenvectors of the ellipsoid and the extents along each axis are +/- the outer background shell radius multiplied by some scale factor (it uses the peak radius if no background is supplied). This means that if the colorfill axes extents are set to [-1,1] (i.e. the axes are normalised by the radii along the ellipsoid axes) then the ellipse in each plot can be plotted as a circle.
Fixes #35708
Report to: Pascal (WISH)
To test:
(1) Run this script
A typical peak will look like this

(2) Integrate peaks without a background and re-run
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.