Add check for groups in SaveNXcanSAS #38892
Open
+8
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently added the capability to input groups in SaveNXcanSAS algorithm #38504.
The algorithm class checks for group workspaces in the input property and if so, it launches a different method to process the groups (processGroups). That method was overridden in order to handle input workspace groups separately in #38504.
Additionally, if any of the workspace property is a group, processGroup method will be called back. In the case of SaveNXcanSAS, it is also possible to input a transmission workspace and tranmission can workspace properties as groups, this was causing a crash when trying to input these properties as groups, as the processGroup method is called when it shouldn't.
To fix this, I have also overriden the checkGroups method from the base algorithm class to specify that processGroups shall only be called when the input workspace property is a group.
There is no associated issue.
Further detail of work
This is an edge case, as the workspace property validator that checks for workspace with given units (in this case wavelength) seems to be selecting also the workspace group name if all the workspace members of a group have the correct unit. Not sure if this an intended behaviour of the workspace property or a bug, but it may merit a separate investigation.
To test:
This does not require release notes because is a regression.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.