Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of PoldiAutoCorrelation algorithm (v6) post detector upgrade #38898

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

RichardWaiteSTFC
Copy link
Contributor

@RichardWaiteSTFC RichardWaiteSTFC commented Feb 19, 2025

Description of work

DRAFT

Summary of work

Fixes #xxxx.

Further detail of work

To test:

(1) Run this script

# import mantid algorithms, numpy and matplotlib
from mantid.simpleapi import *
import matplotlib.pyplot as plt
import numpy as np
from plugins.algorithms.poldi_utils import load_poldi
from os import path


data_dir = r"C:\Users\xhg73778\Documents\POLDI"
fpath_idf = path.join(data_dir, "POLDI_Definition_newDet_10binsPchannel - kopie.xml")
fpath_data = path.join(data_dir, "summedDiffractograms4480x500", "summedDiffractograms.txt")

ws = load_poldi(fpath_data, fpath_idf, xmax=3000, chopper_speed=5000, t0=0.025701, t0_const=85.0)
ws_corr = PoldiAutoCorrelation(InputWorkspace='ws', OutputWorkspace='ws_corr')

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@RichardWaiteSTFC RichardWaiteSTFC changed the title New version of POLDIAutoCorrelation algorithm (v6) post detector upgrade New version of PoldiAutoCorrelation algorithm (v6) post detector upgrade Feb 19, 2025
@sf1919
Copy link
Contributor

sf1919 commented Feb 20, 2025

I re-ran the Linux tests (unit & system, packaging and docs) after main was fixed yesterday. Please treat those failures as genuine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants