-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hdf4 support from NexusCpp #38954
Draft
peterfpeterson
wants to merge
8
commits into
mantidproject:main
Choose a base branch
from
peterfpeterson:38332_disable_hdf4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Remove hdf4 support from NexusCpp #38954
peterfpeterson
wants to merge
8
commits into
mantidproject:main
from
peterfpeterson:38332_disable_hdf4
+1,216
−1,943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2cd36c9
to
344015c
Compare
👋 Hi, @peterfpeterson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
cbde2c5
to
14777bf
Compare
14777bf
to
971c9cc
Compare
👋 Hi, @peterfpeterson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Has Conflicts
Used by the bot to label pull requests that have conflicts
Maintenance
Unassigned issues to be addressed in the next maintenance period.
Technical Debt
Marks a piece of work to address technical debt introduced to solve a problem quickly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
The change to
LegacyNexus
's make is because I discovered it was usingset_target_properties
incorrectly and the flag was making it in through find cmake find modules.Summary of work
Refs #38332
Further detail of work
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.