Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to main nightly publishing only after the release is published #38986

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thomashampson
Copy link
Contributor

Description of work

Currently the Move instruction to restart main nightly publishing to after the release is published instructs the technical release manager to switch from release-next nightly publishing to main nightly publishing right before smoke testing.

It is probably safer to do this after the release has been published. Otherwise if smoke testing fails, and release is delayed, the nightly will be too far ahead too soon.

There is no associated issue.

To test:

  • Do you agree with my logic?

This does not require release notes because it is an update to dev docs.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@thomashampson thomashampson added ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS DevOps Issues and pull requests related to DevOps labels Feb 26, 2025
@thomashampson thomashampson added this to the Release 6.13 milestone Feb 26, 2025
@thomashampson thomashampson added the Documentation Issues and pull requests related to documentation label Feb 26, 2025
@thomashampson thomashampson changed the title Switch back to main nightly publishing to after the release is published Switch back to main nightly publishing only after the release is published Feb 26, 2025
@cailafinn cailafinn self-assigned this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps Issues and pull requests related to DevOps Documentation Issues and pull requests related to documentation ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
Status: Awaiting Merge
Development

Successfully merging this pull request may close these issues.

3 participants