Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberInput bug on Smaprtphone #4912

Closed
Kenzo-Wada opened this issue Sep 28, 2023 · 4 comments · Fixed by #4916
Closed

NumberInput bug on Smaprtphone #4912

Kenzo-Wada opened this issue Sep 28, 2023 · 4 comments · Fixed by #4916
Labels
TBD It is clear how to fix the issue and the fix will be provided soon

Comments

@Kenzo-Wada
Copy link
Contributor

Kenzo-Wada commented Sep 28, 2023

What package has an issue

@mantine/core

Describe the bug

  • When entering a number in NumberInput, the input value becomes incorrect if you input more than two digits on a smartphone using japanese keyboard. Specifically, it occurs in the following way:

10 -> 11010
23 -> 22323

  • Olso, is entering number larger than 1111111111111111, the rest of the number will become 0. (ex. 1111111111111111200000000000). when this occurs, increment or decrement will now work at all. this occurs not only japanese keyboard.

What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

7.0.0

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

None

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Possible fix

There is a possibility that there may be something wrong with the event handler or state management, so those should be corrected. Additionally, it might be worthwhile to consider whether the NumberInput should really have type="number" as the default.

@rtivital rtivital added help wanted Contributions from community are welcome Fix Unknown It is not clear whether the can be resolved labels Sep 29, 2023
@saeidalidadi
Copy link
Contributor

saeidalidadi commented Oct 1, 2023

This issue also exists on all devices. numbers with a length of 16 digits and more have this issue.
I can work on this.

@rtivital
Copy link
Member

rtivital commented Oct 1, 2023

You are welcome to submit a PR with a fix if #4916 does not resolve the issue

@saeidalidadi
Copy link
Contributor

#4916 fixes this one too.

@rtivital rtivital added TBD It is clear how to fix the issue and the fix will be provided soon and removed help wanted Contributions from community are welcome Fix Unknown It is not clear whether the can be resolved labels Oct 1, 2023
@rtivital
Copy link
Member

rtivital commented Oct 1, 2023

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TBD It is clear how to fix the issue and the fix will be provided soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants