Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract class #1

Open
modir opened this issue Mar 26, 2017 · 1 comment
Open

Abstract class #1

modir opened this issue Mar 26, 2017 · 1 comment

Comments

@modir
Copy link

modir commented Mar 26, 2017

I would recommend that you define as well an abstract class which needs to be implemented. This way you make sure that all authentication plugins have the required methods defined.

@vboctor
Copy link
Member

vboctor commented Apr 9, 2017

The AuthFlags are now defined as a flag. AuthFlags are also now created in the context of a specific user (whether in db or unknown user), the plugin can then decide based on the passed user whether it should return null or return auth flags for that user. Hence, enabling per user authentication policy.

Let me know if this handles your request. Note that the SamplePlugin and Auth Plugins PR are now updated to reflect such design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants