Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login flow is hard to grok #7

Open
tgulacsi opened this issue Jun 18, 2022 · 0 comments
Open

Login flow is hard to grok #7

tgulacsi opened this issue Jun 18, 2022 · 0 comments

Comments

@tgulacsi
Copy link

Hi, I've made a 2FA (using https://github.com/PHPGangsta/GoogleAuthenticator),
and the hardest part was to understand that

  1. Iogin_page.php is called first, always
  2. this is followed by login_password_page.php, or what is set in AuthFlags->login_credentials_page,
  3. which must have it's own checking (post to it's own page), before
  4. it shall pass to the original login.php at last.

not bad and totally understandable, but was two days to decipher and try-and-error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant