Always replace User Placeholders with username

MantisBT 2.12.0 changed the way to control the display of users' real
name.

Because of this, user Placeholders were replaced by the realname instead
of the username if the following configuration is used and the current
user's access level is >= $g_show_user_realname_threshold:

    $g_show_realname = ON;
    $g_show_user_realname_threshold = DEVELOPER;

When using such a snippet, real names would be stored in the database,
and thus become visible to any user, even those who are not allowed to
view real names.

To avoid the problem, we now always replace User Placeholders with the
username, regardless of show_realname settings.

Fixes #37

Signed-off-by: Damien Regad <[email protected]>

Original commit message reworded.

Author: atrol

Snippets.API.php

@@ -140,16 +140,16 @@ public static function patterns($snippets, $bug_id) {
 			$bug = bug_get($bug_id);
 			user_cache_array_rows(array($bug->reporter_id, $bug->handler_id, $current_user));
 
-			$reporter = user_get_name($bug->reporter_id);
+			$reporter = user_get_username($bug->reporter_id);
 
 			if($bug->handler_id != NO_USER) {
-				$handler = user_get_name($bug->handler_id);
+				$handler = user_get_username($bug->handler_id);
 			}
 
 			$project = project_get_name($bug->project_id);
-            $username = user_get_name($current_user);
+            $username = user_get_username($current_user);
 		} else {
-            $username = user_get_name($current_user);
+            $username = user_get_username($current_user);
             $reporter = $username;
 			$project = project_get_name(helper_get_current_project());
 		}