Gitlab - update fails when branch qty > gitlab REST API pagination default setting

[fmancardi]

I've a repo with 22 branches and obviously this is greater than Gitlab default -> 20.
Please add at least add '&per_page=50' or may be '&per_page=100' when building the uri in the following function
public function import_full( $p_repo ) {

# Always pull back full list of repos
$t_repoid = $p_repo->info['hub_repoid'];
$t_uri = $this->api_uri( $p_repo, "projects/$t_repoid/repository/branches" );

# My silly FIX !!! - fmancardi
$t_uri .= '&per_page=50';

may be there is a better solution.
And maybe this '&per_page=xx' need to be added to other REST API call

Best regards

[dregad]

@fmancardi it would probably be better to implement pagination in this case, as if we just bump the per_page limit sooner or later you or someone else will hit the new limit.

The Gitlab plugin is community-maintained, so contributions are welcome.

I suggest you have a look at how this is done in the SourceGithub plugin, the logic can probably be applied to Gitlab fairly easily.

[fmancardi]

Thanks a lot Il Gio 28 Apr 2022, 11:04 Damien Regad ***@***.***> ha scritto:

…

@fmancardi <https://github.com/fmancardi> it would probably be better to implement pagination in this case, as if we just bump the per_page limit sooner or later you or someone else will hit the new limit. The Gitlab plugin is community-maintained, so contributions are welcome. I suggest you have a look at how this is done in the SourceGithub plugin <https://github.com/mantisbt-plugins/source-integration/blob/v2.5.1/SourceGithub/SourceGithub.php#L502>, the logic can probably be applied to Gitlab fairly easily. — Reply to this email directly, view it on GitHub <#389 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABZRMJOLVSL4TX3JWIF3CLVHJIBDANCNFSM5PIE2NAA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[dregad]

See #271 (comment)