Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement if procedure #37

Open
jfrioux opened this issue Dec 15, 2018 · 3 comments
Open

Implement if procedure #37

jfrioux opened this issue Dec 15, 2018 · 3 comments
Assignees
Labels
M medium size
Milestone

Comments

@jfrioux
Copy link
Member

jfrioux commented Dec 15, 2018

Implement the if Leaf Procedure.

Review how Floristry::ParametersInterpreter handles Flor constructs.


We need to display in the _if.html.erb partial the condition, the else, and their sequences:

View

if (1=1)
  ▼ sequence ▼
    do_this
else
  ▼ sequence ▼
    do_that

Flor definition

if (1=1)
  sequence # then
    do_this
  sequence # else
    do_that

Solution should define a reusable pattern for the other 2 unimplemented procedures: concurrence and cron.

@jfrioux jfrioux added the M medium size label Dec 15, 2018
@jfrioux jfrioux added this to the First release milestone Dec 15, 2018
@jfrioux jfrioux self-assigned this Dec 15, 2018
@northox
Copy link
Member

northox commented Dec 15, 2018

Im really unsure of what you are talking about here. An if basically have the same representation as the concurrencen: two paths. The only difference is only one of the path is ever used and the partial needs to display the condition. Also, concurrence is implemented, just like sequence. Please explain.

jfrioux added a commit to jfrioux/floristry that referenced this issue Feb 18, 2019
jfrioux added a commit to jfrioux/floristry that referenced this issue Feb 18, 2019
…aling with nested children sequence/concurence/if.

Related to mantor#37
jfrioux added a commit to jfrioux/floristry that referenced this issue Feb 18, 2019
jfrioux added a commit that referenced this issue Apr 27, 2019
* Introduce reference to "raw" params

* Delegate accessor :raw_params to @parameters (parameter_interpreter)

* Add duration method to Sleep model to move out parameters handling out of the partial

* Introduce Att model.

Related to #37

* Fix child nid, prepending exid twice or many times before nid when dealing with nested children sequence/concurence/if.

Related to #37

* Unskip if spec, update fixture, and complete if spec

Related to #37

* Make If a branch procedure, and v1 of view

* Align sqlite version (1.3.6) with ActiveRecord 4.2.8 requirement

* Fix edit spec: current nid format
@jfrioux
Copy link
Member Author

jfrioux commented Nov 30, 2020

Will be working on accessing the payload from the if to enable decisions based on the workflow's context.

@northox
Copy link
Member

northox commented Dec 1, 2020 via email

jfrioux added a commit to jfrioux/floristry that referenced this issue Feb 8, 2021
jfrioux added a commit that referenced this issue Feb 20, 2021
* If condition rendering.
Related to #37

* Remove except clause from payload rendering in FloTask view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M medium size
Projects
None yet
Development

No branches or pull requests

2 participants