Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI tests against all multiple databases #2450

Open
Tracked by #3364
Floppy opened this issue Jul 26, 2024 · 2 comments
Open
Tracked by #3364

Run CI tests against all multiple databases #2450

Floppy opened this issue Jul 26, 2024 · 2 comments
Labels
help wanted Extra attention is needed improvement Refactors and behind-the-scenes improvements

Comments

@Floppy
Copy link
Collaborator

Floppy commented Jul 26, 2024

Because there are some variations in databases (see PRs #2449 and #2448 for examples), we should test against them all in our CI, perhaps in a nightly or pre-release task, not the regular build.

The test should run the standard and migration test suites (see #3363) with all the databases/version combinations listed below. We should test against anything that's officially supported, as shown on the relevant https://endoflife.date page. The table below shows the state as at the time of writing.

Database Versions
SQLite3 built-in version only, covered by standard test setup
PostgreSQL 13, 14, 15, 16, 17
MySQL 8.0, 8.4, 9.1
MariaDB 10.5, 10.6, 10.11, 11.4, 11.6
Redis 7.4, 7.2, 6.2
Valkey 7.2

Presumably, we can use some sort of github actions matrix test setup to bring up the required database, set DATABASE_URL (or REDIS_URL), then run the test suite.

@Floppy Floppy added the improvement Refactors and behind-the-scenes improvements label Jul 26, 2024
@Floppy Floppy added the good first issue Good for newcomers label Oct 6, 2024
@Floppy Floppy removed the good first issue Good for newcomers label Jan 7, 2025
@Floppy Floppy added the help wanted Extra attention is needed label Jan 7, 2025
@julianharty
Copy link

Would you like to also test on various releases of operating systems? or are the issues more likely to be solely a factor of the database product and the database release?

@Floppy
Copy link
Collaborator Author

Floppy commented Jan 8, 2025

Good point - there's a bullet in #3364 about testing on different architectures, I've added OS to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed improvement Refactors and behind-the-scenes improvements
Projects
None yet
Development

No branches or pull requests

2 participants