Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong value for "cmf_descriptor_path" generated by Event Config tool #195

Open
andrewphilipsmith opened this issue Nov 21, 2020 · 2 comments
Assignees

Comments

@andrewphilipsmith
Copy link
Member

andrewphilipsmith commented Nov 21, 2020

Expected Behavior

The outputed json file should contain a key, value pair, where the key is ""cmf_descriptor_path" and the value is the relavite path to the cmf description file. These are examples of valid values:

# the default value
  "cmf_descriptor_path": "cmf_description.json",

# any arbitary name
  "cmf_descriptor_path": "my_crash_move_folder.json",

# a relitive path
  "cmf_descriptor_path": "../a_different_location/cmf_description.json",

As a minimum the Config tool should check that the specified cmf description file exists. Ideally the Config tool should also check that the cmf description file is itself valid - the reference inplenmenation for this is https://github.com/mapaction/mapactionpy_controller/blob/master/mapactionpy_controller/event.py

For a complete check the event description file should verify against the relevant schema file, currently in this dir https://github.com/mapaction/mapactionpy_controller/tree/master/mapactionpy_controller/schemas
It should be documented which version of the schema is used.

The most comprehensive description of how this file should be updated is currently here https://wiki.mapaction.org/x/xoKPDQ

Actual Behavior

The outputed json contains the key, value pair like this example:

  "cmf_descriptor_path": "D:/MapAction/metis/test-data/2019lka01",
  1. It should be the relitive path, not the absolute path.
  2. It should be the name of the file which describes the cmf, not the root of the cmf itself.
  3. The config tools does not check whether the description file exists.
  4. It proscribes the names of the files event_description.json and cmf_descrition.json, rather then merely treating those names as conventions.

Steps to Reproduce the Problem

  1. Open ArcMap and open the Event Config Tool
  2. Create a new event config file.

Specifications

  • Toolbar Version: Version 4.1.7608.35240, Compiled 30/10/2020 19:34
  • ArcGIS Version and Edition: ArcMap v10.6.1
  • MapAction laptop (yes/no): Yes (ma-lapotp37)
  • Windows Version: Windows 10 64bit
@andrewphilipsmith
Copy link
Member Author

Just edited the description to include a comment about the schema of the event description.

@shurst-ma shurst-ma self-assigned this Nov 22, 2020
@andrewphilipsmith
Copy link
Member Author

I've added this line into the the description above; "The most comprehensive description of how this file should be updated is currently here https://wiki.mapaction.org/x/xoKPDQ"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants