Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #4536 merged without successful status checks (mapbox-navigation-ios) #4540

Closed
mapbox-github-ci-issues-2 bot opened this issue Sep 4, 2023 · 0 comments

Comments

@mapbox-github-ci-issues-2
Copy link

👋 Hey there! It's Changebot, and I help repositories follow our engineering best practices. My magic wand found some things I wanted to highlight for your review:

Item Current status Required? Best practice guidelines
Run unsuccessful: ci/circleci: Publish Documentation pending required success
Run unsuccessful: ci/circleci: Core integration test; Xcode 14.1; iOS 16.1 failure optional success
Run unsuccessful: ci/circleci: Xcode_14.1.0_iOS_16.1_Release failure required success
Run unsuccessful: ci/circleci: Xcode 14.3.1; iOS 16.4; SPM Core test failure required success
Run unsuccessful: ci/circleci: Xcode_14.1.0_iOS_16.1_SPM_Release failure required success
Run unsuccessful: ci/circleci: Xcode_14.3.1_iOS_16.4_Debug failure required success
Run unsuccessful: ci/circleci: Xcode_14.3.1 pod update failure required success
Run unsuccessful: ci/circleci: Build Example failure required success
Run unsuccessful: ci/circleci: Xcode_14.1_iOS_16.1_SPM_Debug failure required success
Run unsuccessful: ci/circleci: Xcode_14.1.0_iOS_15.5 failure optional success
Run unsuccessful: ci/circleci: Xcode_14.1_iOS_16.1 failure required success
Run unsuccessful: ci/circleci: Get new API logs failure optional success
Run unsuccessful: ci/circleci: Get old API logs failure optional success
Run unsuccessful: ci/circleci: Xcode_14.2.0 pod install failure required success
Run unsuccessful: Analyze (swift) failure optional success

The following PR was merged without the status checks passing: #4536

Can you take a look at these best practices and make any adjustments if needed?

Please tag @mapbox/security-and-compliance on this issue if you have any questions

@kried kried closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant