Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #4525 merged without successful status checks (mapbox-navigation-ios) #4556

Closed
mapbox-github-ci-issues-1 bot opened this issue Sep 29, 2023 · 1 comment

Comments

@mapbox-github-ci-issues-1
Copy link

👋 Hey there! It's Changebot, and I help repositories follow our engineering best practices. My magic wand found some things I wanted to highlight for your review:

Item Current status Required? Best practice guidelines
Run unsuccessful: publisher-deployer neutral optional success
Run unsuccessful: CodeQL neutral optional success
Run unsuccessful: Analyze (swift) failure optional success

The following PR was merged without the status checks passing: #4525

Can you take a look at these best practices and make any adjustments if needed?

Please tag @mapbox/security-and-compliance on this issue if you have any questions

@Udumft
Copy link
Contributor

Udumft commented Sep 29, 2023

Checks were re-run and successfull after pulling changes from external fork

@Udumft Udumft closed this as completed Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant